Client impl #3
Merged
Client impl #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage SummaryTotals
FilesExpand
|
CostinCarabas
approved these changes
Oct 24, 2024
| @@ -9,4 +13,11 @@ pub trait UtilsModule { | |||
| "Invalid address" | |||
| ); | |||
| } | |||
|
|
|||
| fn checked_timestamp_to_unix_mul(&self, timestamp: Timestamp) -> Timestamp { | |||
| match timestamp.checked_mul(NANO_SECONDS_MULT) { | |||
There was a problem hiding this comment.
Here is just a value in nanoseconds rounded to seconds. If precision is needed, we need framework support. Still figuring it out if it's important
There was a problem hiding this comment.
Doesn't seem like we will need the precision. As far as I'm aware, these timestamps are used to give a timeout for transactions.
| fn update_client_commitments( | ||
| &self, | ||
| client_id: ClientId<Self::Api>, | ||
| encoded_heights: ManagedBuffer, |
There was a problem hiding this comment.
I think a ManagedVec<height::Data> should be here.
There was a problem hiding this comment.
Good point. Didn't realize it at the time. Will keep a list of all these things and fix them in a future PR, don't want to merge all the branches again.
| let ibc_handler = self.ibc_handler().get(); | ||
| let _: () = self | ||
| .client_proxy(ibc_handler) | ||
| .update_client_commitments(client_id, ManagedBuffer::new()) |
There was a problem hiding this comment.
nah, this is just a test contract as far as I'm aware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.