Remove sdk-network-providers from the dependencies #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhtudormorar
approved these changes
Dec 21, 2023
CiprianDraghici
deleted the
cd/refactor/remove-network-providers-from-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
Remove
sdk-network-providersfrom the dependenciesReproduce
Issue exists on version
2.26of sdk-dapp.Root cause
The package isn't used extensively and its existence is not necessary anymore
Fix
Additional changes
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests