update skip method to clear only initiated login state #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreigiura
previously approved these changes
Nov 4, 2024
razvantomegea
approved these changes
Nov 4, 2024
arhtudormorar
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When logging into another with Web Wallet cross window multiple tabs where opened if another wallet tab is already open
Reproduce
Open a wallet tab and in parallel open a dapp and try login with web wallet cross window
Issue exists on version
2.40.11of sdk-dapp.Root cause
When the provider is already initialised the clearInitiatedLogins tries to close all other logins providers sessions instead of clearing the cross window session
Fix
Change clearInitiatedLogins to only clear cross window provider session
Additional changes
No
Contains breaking changes
No
Updated CHANGELOG
Testing