fixes after review

multiversx · Feb 14, 2024 · 9b7f2f2 · 9b7f2f2
1 parent e7e10fe
commit 9b7f2f2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/message.ts b/src/message.ts
@@ -20,7 +20,7 @@ export class Message {
     /**
      * Number representing the message version.
      */
-    public version?: number;
+    public version: number;
 
     constructor(options: { data: Uint8Array; signature?: Uint8Array; address?: IAddress; version?: number }) {
         this.data = options.data;
@@ -60,14 +60,11 @@ export class MessageComputer {
     }
 
     unpackMessage(packedMessage: { message: string; signature?: string; address?: string; version?: number }): Message {
-        let dataHex = this.trimHexPrefix(packedMessage.message);
+        const dataHex = this.trimHexPrefix(packedMessage.message);
         const data = Buffer.from(dataHex, "hex");
 
-        let signature: Uint8Array | undefined = undefined;
-        if (packedMessage.signature) {
-            let signatureHex = this.trimHexPrefix(packedMessage.signature);
-            signature = Buffer.from(signatureHex, "hex");
-        }
+        const signatureHex = this.trimHexPrefix(packedMessage.signature || "");
+        const signature = Buffer.from(signatureHex, "hex");
 
         let address: Address | undefined = undefined;
         if (packedMessage.address) {

diff --git a/src/transactionsFactories/relayedTransactionsFactory.ts b/src/transactionsFactories/relayedTransactionsFactory.ts
@@ -14,7 +14,7 @@ interface IConfig {
 }
 
 /**
- * Use this class to create both RelyedV1 and RelayedV2 transactions.
+ * Use this class to create both RelayedV1 and RelayedV2 transactions.
  */
 export class RelayedTransactionsFactory {
     private readonly config: IConfig;