Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (replace) "instanceof Buffer" from applySignature() #302

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Remove (replace) "instanceof Buffer" from applySignature() #302

merged 5 commits into from
Jun 20, 2023

Conversation

andreibancioiu
Copy link
Contributor

Instanceof Buffer fails to work properly on some build systems.

@andreibancioiu andreibancioiu self-assigned this Jun 20, 2023
@andreibancioiu andreibancioiu marked this pull request as ready for review June 20, 2023 10:33
@andreibancioiu andreibancioiu merged commit 3cbe864 into main Jun 20, 2023
1 check passed
@andreibancioiu andreibancioiu deleted the apply-signature-instance-of-buffer branch June 20, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiprianDraghici CiprianDraghici CiprianDraghici approved these changes

@ccorcoveanu ccorcoveanu ccorcoveanu approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @CiprianDraghici @ccorcoveanu