Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applySignature(). Handle buffers in a better way #349

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix applySignature(). Handle buffers in a better way #349

merged 2 commits into from
Nov 8, 2023

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Nov 8, 2023 •
edited
Loading

  • Apply the same logic for both messages and transactions.
  • Move interpretSignatureAsBuffer to signature.ts.

@andreibancioiu andreibancioiu self-assigned this Nov 8, 2023
@andreibancioiu andreibancioiu marked this pull request as ready for review November 8, 2023 11:17
MiroMargineanu
MiroMargineanu requested changes Nov 8, 2023
View reviewed changes
src/signature.ts Show resolved Hide resolved
@MiroMargineanu MiroMargineanu merged commit 8d75a32 into main Nov 8, 2023
1 check passed
@andreibancioiu andreibancioiu deleted the apply-signature-08 branch November 8, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielailie danielailie danielailie approved these changes

@andreigiura andreigiura andreigiura approved these changes

@MiroMargineanu MiroMargineanu MiroMargineanu approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreibancioiu @danielailie @andreigiura @MiroMargineanu