Implemented the Relayed Transactions Factory #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
previously approved these changes
Jan 8, 2024
bogdan-rosianu
previously approved these changes
Jan 8, 2024
andreibancioiu
previously approved these changes
Jan 19, 2024
| sender: Address.fromBech32(innerTransaction.sender).pubkey().toString("base64"), | ||
| receiver: Address.fromBech32(innerTransaction.receiver).pubkey().toString("base64"), | ||
| value: new BigNumber(innerTransaction.value.toString(), 10).toNumber(), | ||
| gasPrice: new BigNumber(innerTransaction.gasPrice.toString(), 10).toNumber(), |
There was a problem hiding this comment.
Could have also been new BigNumber(innerTransaction.value), I think etc.
popenta
dismissed stale reviews from andreibancioiu and bogdan-rosianu
via
c027a00
bogdan-rosianu
approved these changes
Jan 19, 2024
ccorcoveanu
approved these changes
Jan 19, 2024
andreibancioiu
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RelayedTransactionsFactorywas implemented according to the sdk-specs.Also added unit tests.