Send Native token in MultiESDTNFTTransfer #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Jul 2, 2024
|
|
||
| if (nativeTransferAmount && numberOfTokens) { | ||
| throw new ErrBadUsage("Can't send both native tokens and custom tokens(ESDT/NFT)"); | ||
| const nativeTransfer = TokenTransfer.newFromEgldAmount(nativeTransferAmount); | ||
| tokenTransfers.push(nativeTransfer); |
There was a problem hiding this comment.
Maybe use array concatenation, similar to Python?
| @@ -82,18 +82,10 @@ export class TransferTransactionsFactory { | |||
| return this.gasEstimator !== undefined; | |||
| } | |||
|
|
|||
| private ensureMembersAreDefined() { | |||
| private ensureConfigIsDefined() { | |||
There was a problem hiding this comment.
Indeed, the presence of this.config indicates the presence of tokenComputer and tokenTransfersDataBuilder, as well. Also, we can set this.tokenComputer and this.tokenTransfersDataBuilder in constructor no matter what (irrespective to isGasEstimator()).
In v14, this is the first legacy thing to be dropped :)
| } | ||
|
|
||
| const nativeTransfer = nativeAmount ? TokenTransfer.newFromEgldAmount(nativeAmount) : undefined; | ||
| nativeTransfer ? tokenTransfers.push(nativeTransfer) : null; |
There was a problem hiding this comment.
As mentioned above, array concatenation can be used (optional).
andreibancioiu
previously approved these changes
Jul 8, 2024
bogdan-rosianu
approved these changes
Jul 9, 2024
andreibancioiu
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to send both native and esdt tokens using
MultiESDTNFTTransfer.