Add convert to bool if string or number receive for boolean value #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }).getEndpoint("foo"); | ||
|
|
||
| let typedValues = NativeSerializer.nativeToTypedValues( | ||
| [true, "true", "TRUE", 1, false, "false", "falseString", 0, 5], |
| }).getEndpoint("foo"); | ||
|
|
||
| let typedValues = NativeSerializer.nativeToTypedValues( | ||
| [true, "true", "TRUE", 1, false, "false", "falseString", 0, 5], |
There was a problem hiding this comment.
"falseString" can be "foobar" - test is thus more explicit about arbitrary strings.
| @@ -610,4 +610,59 @@ describe("test native serializer", () => { | |||
| variadic: false, | |||
| }); | |||
| }); | |||
|
|
|||
| it.only("should accept a mixed of values for boolen type", async () => { | |||
| @@ -296,7 +296,8 @@ export namespace NativeSerializer { | |||
| return new AddressValue(convertNativeToAddress(native, errorContext)); | |||
| } | |||
| if (type instanceof BooleanType) { | |||
| return new BooleanValue(native); | |||
| const boolValue = native.toString().toLowerCase() === "true" || native.toString() === "1"; | |||
There was a problem hiding this comment.
Wouldn't this be more appropriate in the "isTrue" evaluation?
There was a problem hiding this comment.
the value from BooleanValue is expected to be bool, here we accept any type that's why we thought it's better to be here
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@multiversx/sdk-core", | |||
| "version": "13.2.2", | |||
| "version": "13.2.3", | |||
There was a problem hiding this comment.
Let's bump the minor version, so that developers take this update intentionally (not as a hotfix) - v13.3.0.
andreibancioiu
approved these changes
Aug 6, 2024
ccorcoveanu
approved these changes
Aug 6, 2024
danielailie
deleted the
TOOL-220-add-check-for-boolean-value-to-increase-clarity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convert to bool before creating the boolean value to cover the scenarios where boolean value is passed as string or number.
This is a follow up at this issue #258