Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run npm audit fix, add missing info in package.json #474

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Run npm audit fix, add missing info in package.json #474

merged 2 commits into from
Aug 28, 2024

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Aug 27, 2024 •
edited
Loading

  • Run npm audit fix
  • Add missing info in package.json
  • Fix CodeQL warning (within test code)

@andreibancioiu andreibancioiu self-assigned this Aug 27, 2024
andreibancioiu
andreibancioiu commented Aug 27, 2024
View reviewed changes
package.json
"author": "MultiversX",
"homepage": "https://multiversx.com",
"license": "MIT",
"repository": "github:multiversx/mx-sdk-js-core",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository

andreibancioiu
andreibancioiu commented Aug 27, 2024
View reviewed changes
package.json
"url": "https://github.com/multiversx/mx-sdk-js-core/issues"
},
"keywords": [
"multiversx",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/web3/web3.js/blob/4.x/package.json#L7

@andreibancioiu andreibancioiu merged commit 3901f3f into main Aug 28, 2024
3 checks passed
@andreibancioiu andreibancioiu deleted the package-bureaucracy-1 branch August 28, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidrasovean danidrasovean danidrasovean approved these changes

@radumojic radumojic radumojic approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @radumojic @danidrasovean