Add prefix handling for esdt prefix #526
Conversation
danielailie
changed the title
src/tokens.ts
Outdated
| @@ -249,19 +249,31 @@ export class TokenComputer { | |||
|
|
|||
| extractIdentifierFromExtendedIdentifier(identifier: string): string { | |||
| const parts = identifier.split("-"); | |||
| const { prefix, ticker, randomnes } = this.splitIdentifierIntoComponent(parts); | |||
There was a problem hiding this comment.
typo in randomness. can also be renamed to randomSequence.
src/tokens.ts
Outdated
| @@ -281,6 +293,15 @@ export class TokenComputer { | |||
| } | |||
| } | |||
|
|
|||
| private checkLengthOfPrefix(prefix: string): void { | |||
| const TOKEN_PREFIX_LENGTH = 4; | |||
| if (prefix.length > TOKEN_PREFIX_LENGTH) { | |||
There was a problem hiding this comment.
maybe we should also check that the length of the prefix is at least 1.
src/tokens.ts
Outdated
| @@ -249,19 +249,31 @@ export class TokenComputer { | |||
|
|
|||
| extractIdentifierFromExtendedIdentifier(identifier: string): string { | |||
| const parts = identifier.split("-"); | |||
| const { prefix, ticker, randomnes } = this.splitIdentifierIntoComponent(parts); | |||
There was a problem hiding this comment.
Typo 🙃
randomness and components.
src/tokens.ts
Outdated
| return ticker + "-" + randomnes; | ||
| } | ||
|
|
||
| splitIdentifierIntoComponent(parts: string[]): { prefix: any; ticker: any; randomnes: any } { |
There was a problem hiding this comment.
Can we have this as private?
src/tokens.ts
Outdated
| } | ||
|
|
||
| splitIdentifierIntoComponent(parts: string[]): { prefix: any; ticker: any; randomnes: any } { | ||
| if (parts.length >= 3 && parts[2].length === 6) { |
There was a problem hiding this comment.
In other functions, we have constants defined (for 3 and 6).
There was a problem hiding this comment.
How would it be to contain the const parts = identifier.split("-"); itself within this function, too? 🌨️
There was a problem hiding this comment.
I don't know what name should I use for 3, any suggestions
?
| this.validateExtendedIdentifier(prefix, randomSequence, ticker, parts); | ||
| if (prefix) { | ||
| this.checkLengthOfPrefix(prefix); | ||
| return prefix + "-" + ticker + "-" + randomSequence; |
There was a problem hiding this comment.
We could have had string interpolation / optional 🙃
danielailie
deleted the
TOOL-307-add-esdt-prefix-to-support-sovereign-integration
branch
No description provided.