Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix browser minified output file #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juliancwirko
Copy link
Contributor

There is a problem with minified erdjs for the browser. For the demo from here:

https://gist.github.com/juliancwirko/f31aab85d735d7b86162de4c4da33b1f

When I use erdjs.min.js instead of erdjs.js, I will get the error. See attached image.

bug

After using terser instead of tinyify seems to work well, the compression level is a little bit better, and I think terser is a lot faster.

I've tried to run the browser tests. Some of them fail, but the same is on the development branch.

@andreibancioiu
Copy link
Contributor

andreibancioiu commented Jan 26, 2022

@juliancwirko, thank you for the contribution (and for reporting the error) 🎉

The browser tests issues should be resolved in PR: #101.

Furthermore, thank you for the suggestion on using terser 🚀 .

Though, do you mind if we keep your PR on hold a little bit more (until we fix the issues around browserify & latest versions of wallet connect)?

@juliancwirko
Copy link
Contributor Author

Thanks for the response, and sure, do what is necessary :)

@andreibancioiu andreibancioiu changed the base branch from development to main March 10, 2022 08:50
@andreibancioiu andreibancioiu added the Good idea 💡 Good idea label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants