Checking expected timeouts on check_error too - Fixes mumuki/mumuki-laboratory#1207

lib/checker.rb

@@ -10,11 +10,7 @@ def check_final_board(output, expected)
       status = output[:status]
       result = output[:result]
 
-      is_expected_timeout = result[:finalBoardError] &&
-                                    result[:finalBoardError][:reason][:code] == 'timeout' &&
-                                    @options[:expect_endless_while]
-
-      return if is_expected_timeout
+      return if is_expected_timeout(result)
       assert_not_boom status, result
 
       expected_board = result[:extraBoard]
@@ -40,6 +36,8 @@ def check_error(output, expected)
       status = output[:status]
       result = output[:result]
 
+      return if is_expected_timeout(result)
+
       fail_with status: :check_error_failed_expected_boom,
                 result: {
                   initial: result[:initialBoard],
@@ -97,6 +95,12 @@ def assert_not_boom(status, result)
                 } if status == :runtime_error
     end
 
+    def is_expected_timeout(result)
+      result[:finalBoardError] &&
+      result[:finalBoardError][:reason][:code] == 'timeout' &&
+      @options[:expect_endless_while]
+    end
+
     def fail_with(error)
       fail error.to_json
     end

lib/precompile_hook.rb

@@ -47,14 +47,18 @@ def compile_file_content(request)
   def post_process_file(_file, result, status)
     if status == :passed
       result = result.parse_as_json
-      status = :aborted if is_timeout? result and !@batch.options[:expect_endless_while]
+      status = :aborted if is_timeout? result and !expects_timeout?
     end
 
     [result, status]
   end
 
   private
 
+  def expects_timeout?
+    @batch.options[:expect_endless_while] || @batch.examples.any? { |it| it[:postconditions][:error] == 'timeout' }
+  end
+
   def is_timeout?(result)
     result[0]&.dig(:result, :finalBoardError, :reason, :code) === 'timeout'
   end

lib/render/editor/editor.html

@@ -401,7 +401,6 @@
       },
 
       ready: function () {
-
         const resetStatusAfterAborted = () => {
           $('#kids-results-aborted').on('hidden.bs.modal', () => {
             this.$.runner.isDirty = false;