Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Review Comments #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apply Review Comments #9

wants to merge 1 commit into from

Conversation

musangamfure
Copy link
Owner

Hello @M-AminAlizadeh,

Thanks for your feedback on my Todo List App regarding:

1. JavaScript Best Practices
2. HTML and CSS Best Practices
3. DRY, KISS, and YAGNI Rules.

In this PR, I have corrected all the mistakes regarding the above practices and rules as you have pointed out in your issues message.

Kindly feel free to check what I have done and let me know if there is something else worth considering or any other suggestions.

Best Regards.

@M-AminAlizadeh
Copy link
Collaborator

STATUS: APPROVED 🎉 👏 🍾

Hi @musangamfure ,

You are amazing 😃 👏! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 👏 🎩

  • No linter errors 👍
  • Good use of GitHub flow 👍
  • Professional README file 👏

Optional suggestions 🛩️

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@M-AminAlizadeh M-AminAlizadeh self-requested a review May 13, 2023 15:53
@musangamfure
Copy link
Owner Author

Hello @M-AminAlizadeh,

Thank you so much🙌🙌 for the time and effort you invested in reviewing my project.

I look forward to work with you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants