Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upload success reported as failure in some cases #134

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: upload success reported as failure in some cases #134

merged 1 commit into from
May 13, 2024

Conversation

daytime-em
Copy link
Collaborator

@daytime-em daytime-em commented May 13, 2024 •
edited
Loading

If the metrics server is down, just swallow the error.

@daytime-em daytime-em requested a review from a team as a code owner May 13, 2024 16:26
daytime-em
daytime-em commented May 13, 2024
View reviewed changes
library/src/main/java/com/mux/video/upload/internal/UploadMetrics.kt
@@ -24,16 +24,6 @@ internal class UploadMetrics private constructor() {

private val logger get() = MuxUploadSdk.logger


private fun formatMilliseconds(ms:Long):String {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method wasn't used. It looks like we moved to SimpleDateFormat, which is definitely 👍 👍

cjpillsbury
cjpillsbury approved these changes May 13, 2024
View reviewed changes
Copy link

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@daytime-em daytime-em merged commit 7bb6d30 into releases/v1.0.0 May 13, 2024
3 checks passed
@daytime-em daytime-em deleted the fix/mis-report-when-metrics-down branch May 13, 2024 16:59
daytime-em added a commit that referenced this pull request Jun 13, 2024
@daytime-em
fix: upload success reported as failure in some cases (#134)
c69588d
@daytime-em daytime-em mentioned this pull request Jun 13, 2024
Merged
daytime-em added a commit that referenced this pull request Jun 13, 2024
@daytime-em
Releases/v1.0.0 (#141)
1fb2d37 
## New
* 4k and 720p input standardization (#139)
* Background-Uploading example in sample app (#140)

## Fixes
* fix: currentStatus always reports READY (#135)
* fix: upload success reported as failure in some cases (#134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpillsbury cjpillsbury cjpillsbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daytime-em @cjpillsbury