4K standardization #139
Merged
4K standardization #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
requested changes
Jun 7, 2024
| @@ -0,0 +1,5 @@ | |||
| package com.mux.video.upload.internal.options | |||
|
|
|||
| class DirectUploadOptions { | |||
There was a problem hiding this comment.
If this isn't used, can we delete it?
There was a problem hiding this comment.
Sorry, yes, this is sufficient
andrewjl-mux
reviewed
Jun 7, 2024
| * for use with Mux Video | ||
| */ | ||
| @Suppress("unused") | ||
| fun standardizationRequested(enabled: Boolean, maxResolution: MaximumResolution): Builder { |
There was a problem hiding this comment.
Should the parameter name be updated to requested here?
There was a problem hiding this comment.
Will add in a separate PR, so we can get this merged.
andrewjl-mux
reviewed
Jun 7, 2024
| /** | ||
| * If requested, the Upload SDK will try to standardize the input file in order to optimize it | ||
| * for use with Mux Video | ||
| */ | ||
| @Suppress("unused") | ||
| fun standardizationRequested(enabled: Boolean): Builder { | ||
| uploadInfo.update(standardizationRequested = enabled) | ||
| uploadInfo.update(InputStandardization(enabled)) |
There was a problem hiding this comment.
And here as well, should this be updated to requested?
|
Thanks for the changes, tom!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this doc: https://docs.mux.com/guides/minimize-processing-time#standard-input-specs and @andrewjl-mux Release branch: https://github.com/muxinc/swift-upload-sdk/tree/releases/v1.0.0