chore: update dependencies #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewjl-mux
commented
Sep 30, 2024
•
andrewjl-mux
commented
- Update Mux Data AVPlayer and Core SDK dependencies
- Replace Specta unit tests with XCTest
- Clean-up
* switch to plain text in LICENSE * move run-tests script to scripts * remove unnecessary example files * stop tracking Podfile.lock changes * stop tracking Pods directory content changes * remove old comment about travis CI, it is no longer used
andrewjl-mux
force-pushed
the
ajlb/chore/update-dependencies
branch
3 times, most recently
from
0a2c7dc
to
2a38f7a
Compare
refactor: use init instead of new
andrewjl-mux
force-pushed
the
ajlb/chore/update-dependencies
branch
from
cb1e115
to
2159870
Compare
daytime-em
approved these changes
Sep 30, 2024
andrewjl-mux
force-pushed
the
ajlb/chore/update-dependencies
branch
from
85df9d5
to
44a173e
Compare
andrewjl-mux
force-pushed
the
ajlb/chore/update-dependencies
branch
from
44a173e
to
ba17f6d
Compare
cjpillsbury
reviewed
Oct 1, 2024
andrewjl-mux
commented
Oct 1, 2024
| [_playerBinding dispatchAdEvent: playbackEvent]; | ||
| } else { | ||
| _sendAdplayOnStarted = YES; | ||
| } | ||
| playbackEvent = [MUXSDKAdPlayingEvent new]; | ||
| playbackEvent = [[MUXSDKAdPlayingEvent alloc] init]; |
There was a problem hiding this comment.
Calling alloc and init is equivalent to new. new doesn't support custom initializers (initializers other than init, typically these take an argument). Modern Objective-C recommends use of custom initializers or factory methods (+ (instancetype)factoryMethodA) for more explicitness. See here..
There was a problem hiding this comment.
Everything here is compiled with Automatic Reference Counting enabled, which disallows explicit management of reference counts except in limited circumstances. Bridging calls to older APIs. Not used in this SDK.
andrewjl-mux
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 82e8644.
andrewjl-mux
added a commit
that referenced
this pull request
Oct 1, 2024
|
Release branch PR: #40 |
|
daytime-em
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.