Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger Github Action on all branches #77

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

mvdwetering
Copy link
Owner

@mvdwetering mvdwetering commented Feb 1, 2024

Summary by CodeRabbit

  • Chores
    • Updated workflow triggers to activate on push events to both dev and master branches.

Copy link
Contributor

coderabbitai bot commented Feb 1, 2024

Walkthrough

The recent update to the repository introduces a modification to the workflow configuration. This change specifically enhances the automation by triggering the workflow for both dev and master branches upon push events. It's a strategic improvement aimed at ensuring continuous integration practices are more inclusive of the primary branches involved in the development process, thus facilitating smoother and more efficient code integration and testing processes.

Changes

File Path Change Summary
.github/workflows/push.yaml Added dev and master branches to trigger on push events

🐇✨
In the realm of code, where branches intertwine,
A rabbit hopped, making workflows align.
dev and master, now under its watchful eyes,
Ensuring that with every push, quality flies.
🌟🐾


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c2a898e and 9abb64c.
Files selected for processing (1)
  • .github/workflows/push.yaml (1 hunks)
Additional comments: 2
.github/workflows/push.yaml (2)
  • 5-7: The addition of branch triggers for dev and master is correctly implemented. This change effectively limits workflow triggers to push events on these two branches, aligning with the PR objectives to streamline CI/CD processes for relevant branches only.
  • 2-10: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-44]

Overall, the workflow file is well-structured and follows GitHub Actions best practices. The jobs are clearly defined, and the use of matrix strategy for testing across different Python versions is a good practice for ensuring compatibility. The conditional execution of the release job based on tag names is correctly implemented, ensuring that releases are only created for tagged commits. No further issues or improvements are identified.

@mvdwetering mvdwetering merged commit 2c1d214 into dev Feb 1, 2024
4 checks passed
@mvdwetering mvdwetering deleted the reduce_github_actions_triggered branch February 1, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant