Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBus::Object.dbus_reader_attr_accessor to declare a common use case with a single call. #140

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

mvidner
Copy link
Owner

@mvidner mvidner commented Sep 26, 2023

@jreidinger has used dbus_attr_reader and found the PropertiesChanged signal was missing. This API should make it easier to do the right thing

to declare a common use case with a single call.
to process `code` instead of RDoc +code+
@mvidner mvidner requested a review from jreidinger September 26, 2023 15:30
@coveralls
Copy link

Coverage Status

coverage: 96.644% (+0.005%) from 96.639% when pulling 3c8cbb9 on dbus-reader-attr-accessor into c13dd81 on master.

Copy link
Collaborator

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@mvidner mvidner merged commit 5563a72 into master Sep 27, 2023
14 checks passed
@mvidner mvidner deleted the dbus-reader-attr-accessor branch September 27, 2023 13:20
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Oct 4, 2023
https://build.opensuse.org/request/show/1114915
by user mvidner + anag+factory
- 0.23.1
 API:
 * Add DBus::Object.dbus_reader_attr_accessor to declare a common use case
   with a single call (gh#mvidner/ruby-dbus#140).
 * BusConnection#request_name defaults to the simple use case: single owner
   without queuing, failing fast; documented the complex use cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants