devonfw#343: suppress success message of single step (devonfw#413)

mvomiero · Jun 25, 2024 · 79ff36f · 79ff36f
1 parent e0a2efc
commit 79ff36f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/cli/src/main/java/com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java
@@ -40,12 +40,6 @@ public boolean isIdeHomeRequired() {
  return true;
  }
 
- @Override
- public boolean isSuppressStepSuccess() {
-
- return true;
- }
-
  @Override
  public void run() {
 

diff --git a/cli/src/main/java/com/devonfw/tools/ide/step/StepImpl.java b/cli/src/main/java/com/devonfw/tools/ide/step/StepImpl.java
@@ -147,7 +147,7 @@ private void end(Boolean newSuccess, Throwable error, boolean suppress, String m
  if (newSuccess == null) {
  newSuccess = Boolean.FALSE;
  }
- if (this.success != Boolean.FALSE) { // never allow a failed step to change to success
+ if (!Boolean.FALSE.equals(this.success)) { // never allow a failed step to change to success
  this.duration = delay;
  this.success = newSuccess;
  }
@@ -192,7 +192,7 @@ public void logSummary(boolean suppressSuccess) {
  if (this.context.trace().isEnabled()) {
  this.context.trace(toString());
  }
- if (this.context.isQuietMode()) {
+ if (this.context.isQuietMode() || (this.children.isEmpty() && Boolean.TRUE.equals(this.success))) {
  return;
  }
  StepSummary summary = new StepSummary();