Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of typos. #88

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Fix a number of typos. #88

merged 2 commits into from
Sep 23, 2023

Conversation

schwehr
Copy link
Contributor

@schwehr schwehr commented Sep 19, 2023

The most important is lincense_files in project.toml.

The most important is `lincense_files` in project.toml.
Took the latest from https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html

Got:

```
TypeError: Cannot read properties of undefined (reading 'createComment')
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15143:16), <anonymous>:5:15)
    at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15144:12)
[SNIP]
Error: Unhandled error: TypeError: Cannot read properties of undefined (reading 'createComment')
```
@mwcraig mwcraig self-requested a review September 23, 2023 16:34
Copy link
Owner

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @schwehr!

Does the change to license_files warrant a new release?

@mwcraig mwcraig merged commit ec45401 into mwcraig:main Sep 23, 2023
3 checks passed
@schwehr
Copy link
Contributor Author

schwehr commented Sep 23, 2023

I don't think the change to pyproject.toml needs a new release. I think I am using an overly picky tool and it's not publically available, so most folks won't have a problem.

Thanks for merging the pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants