Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11.0 beta #98

Merged
merged 11 commits into from
Feb 29, 2024
Merged

1.11.0 beta #98

merged 11 commits into from
Feb 29, 2024

Conversation

mwong009
Copy link
Owner

@mwong009 mwong009 commented Feb 21, 2024

Checklist

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Features

  • run: added is_training flag

Fixes

  • added null_log_likelihood_fn to basic.py
  • results.py: add argument for max cutoff in show_training_plot
  • results.py: fixed legend placement on training plot
  • run.py: add option for acceptance_method argument

Documentation

  • news on conda-forge availability
  • update documentation quick-start.md
  • update documentation installation.md

Maintenance

  • minor refactorization

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 38.70968% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 51.62%. Comparing base (88b02f6) to head (c6a48d9).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   51.96%   51.62%   -0.34%     
==========================================
  Files          19       19              
  Lines        1938     1968      +30     
==========================================
+ Hits         1007     1016       +9     
- Misses        931      952      +21     
Files Coverage Δ
pycmtensor/dataset.py 93.49% <100.00%> (+0.05%) ⬆️
pycmtensor/defaultconfig.py 78.78% <100.00%> (+0.66%) ⬆️
pycmtensor/expressions.py 66.10% <ø> (ø)
pycmtensor/logger.py 91.17% <ø> (ø)
pycmtensor/models/MNL.py 82.35% <100.00%> (-1.86%) ⬇️
pycmtensor/optimizers.py 21.40% <ø> (ø)
pycmtensor/scheduler.py 42.59% <ø> (ø)
pycmtensor/statistics.py 100.00% <ø> (ø)
pycmtensor/models/ResLogit.py 0.00% <0.00%> (ø)
pycmtensor/models/TasteNet.py 34.65% <0.00%> (+0.33%) ⬆️
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c6d35...c6a48d9. Read the comment docs.

@mwong009 mwong009 self-assigned this Feb 29, 2024
@mwong009 mwong009 merged commit a53ac5d into master Feb 29, 2024
7 checks passed
@mwong009 mwong009 deleted the 1.11.0-beta branch February 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant