mwylde · Philipp-M · Dec 9, 2023
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/loopers-common/Cargo.toml b/loopers-common/Cargo.toml
@@ -11,8 +11,8 @@ license = "MIT OR Apache-2.0"
 [dependencies]
 bytes = "1.0"
 serde = { version = "1.0", features = ["derive", "rc"] }
-
-csv = "1.1"
+bytemuck = { version = "1", features = ["derive"] }
+csv = "1.3"
 
 crossbeam-queue = "0.3"
 crossbeam-channel = "0.5"

diff --git a/loopers-common/src/api.rs b/loopers-common/src/api.rs
@@ -1,5 +1,5 @@
 use crate::gui_channel::WAVEFORM_DOWNSAMPLE;
-use crate::music::{SavedMetricStructure};
+use crate::music::SavedMetricStructure;
 use derive_more::{Add, Div, Mul, Sub};
 use serde::{Deserialize, Serialize};
 use std::ops::{Index, IndexMut};
@@ -140,7 +140,9 @@ impl LooperCommand {
         use Command::Looper;
         use LooperCommand::*;
 
-        let target_type = args.get(0).ok_or(format!("{} expects a target", command))?;
+        let target_type = args
+            .first()
+            .ok_or(format!("{} expects a target", command))?;
 
         let target = match *target_type {
             "All" => LooperTarget::All,
@@ -173,7 +175,7 @@ impl LooperCommand {
                 } else {
                     let f = f32::from_str(v)
                         .map_err(|_| format!("Invalid value for SetPan: '{}'", v))?;
-                    if f < -1.0 || f > 1.0 {
+                    if !(-1.0..=1.0).contains(&f) {
                         return Err("Value for SetPan must be between -1 and 1".to_string());
                     }
                     Some(f)
@@ -185,7 +187,7 @@ impl LooperCommand {
                         target,
                     )
                 })
-            },
+            }
 
             "SetLevel" => {
                 let v = args.get(1).ok_or(
@@ -197,21 +199,15 @@ impl LooperCommand {
                 } else {
                     let f = f32::from_str(v)
                         .map_err(|_| format!("Invalid value for SetLevel: '{}'", v))?;
-                    if f < 0.0 || f > 1.0 {
+                    if !(0.0..=1.0).contains(&f) {
                         return Err("Value for SetLevel must be between 0 and 1".to_string());
                     }
                     Some(f)
                 };
 
-                Box::new(move |d| {
-                    Looper(
-                        SetLevel(arg.unwrap_or(d.data as f32 / 127.0)),
-                        target,
-                    )
-                })
+                Box::new(move |d| Looper(SetLevel(arg.unwrap_or(d.data as f32 / 127.0)), target))
             }
 
-
             "1/2x" => Box::new(move |_| Looper(SetSpeed(LooperSpeed::Half), target)),
             "1x" => Box::new(move |_| Looper(SetSpeed(LooperSpeed::One), target)),
             "2x" => Box::new(move |_| Looper(SetSpeed(LooperSpeed::Double), target)),
@@ -275,17 +271,17 @@ impl Command {
 
             "SetTime" => {
                 let arg = args
-                    .get(0)
+                    .first()
                     .and_then(|s| i64::from_str(s).ok())
-                    .map(|t| FrameTime(t))
+                    .map(FrameTime)
                     .ok_or("SetTime expects a single numeric argument, time".to_string())?;
                 Box::new(move |_| Command::SetTime(arg))
             }
 
             "AddLooper" => Box::new(|_| Command::AddLooper),
             "SelectLooperById" => {
                 let arg = args
-                    .get(0)
+                    .first()
                     .and_then(|s| u32::from_str(s).ok())
                     .ok_or(
                         "SelectLooperById expects a single numeric argument, the looper id"
@@ -297,7 +293,7 @@ impl Command {
             }
 
             "SelectLooperByIndex" => {
-                let arg = args.get(0).and_then(|s| u8::from_str(s).ok()).ok_or(
+                let arg = args.first().and_then(|s| u8::from_str(s).ok()).ok_or(
                     "SelectLooperByIndex expects a single numeric argument, the looper index"
                         .to_string(),
                 )?;
@@ -311,8 +307,8 @@ impl Command {
             "NextPart" => Box::new(|_| Command::NextPart),
             "GoToPart" => {
                 let arg = args
-                    .get(0)
-                    .and_then(|s| match s.as_ref() {
+                    .first()
+                    .and_then(|s| match *s {
                         "A" => Some(Part::A),
                         "B" => Some(Part::B),
                         "C" => Some(Part::C),
@@ -326,8 +322,8 @@ impl Command {
 
             "SetQuantizationMode" => {
                 let arg = args
-                    .get(0)
-                    .and_then(|s| match s.as_ref() {
+                    .first()
+                    .and_then(|s| match *s {
                         "Free" => Some(QuantizationMode::Free),
                         "Beat" => Some(QuantizationMode::Beat),
                         "Measure" => Some(QuantizationMode::Measure),
@@ -341,7 +337,7 @@ impl Command {
             }
 
             "SetMetronomeLevel" => {
-                let arg = args.get(0).and_then(|s| u8::from_str(s).ok()).ok_or(
+                let arg = args.first().and_then(|s| u8::from_str(s).ok()).ok_or(
                     "SetMetronomeLevel expects a single numeric argument, the level between 0-100"
                         .to_string(),
                 )?;
@@ -404,6 +400,7 @@ impl PartSet {
     }
 
     pub fn is_empty(&self) -> bool {
+        #[allow(clippy::nonminimal_bool)]
         !(self.a || self.b || self.c || self.c)
     }
 }
@@ -440,7 +437,8 @@ impl IndexMut<Part> for PartSet {
 
 pub static PARTS: [Part; 4] = [Part::A, Part::B, Part::C, Part::D];
 
-#[derive(Serialize, Deserialize, Clone, Copy, Debug, Eq, PartialEq, Hash)]
+#[derive(bytemuck::NoUninit, Serialize, Deserialize, Clone, Copy, Debug, Eq, PartialEq, Hash)]
+#[repr(u8)]
 pub enum LooperMode {
     Recording,
     Overdubbing,

diff --git a/loopers-common/src/config.rs b/loopers-common/src/config.rs
@@ -34,7 +34,7 @@ mod tests {
 
         let mapping = MidiMapping::from_file(
             &file.path().to_string_lossy(),
-            &File::open(&file.path()).unwrap(),
+            &File::open(file.path()).unwrap(),
         )
         .unwrap();
 
@@ -74,18 +74,11 @@ mod tests {
 
 pub static FILE_HEADER: &str = "Channel\tController\tData\tCommand\tArg1\tArg2\tArg3";
 
+#[derive(Default)]
 pub struct Config {
     pub midi_mappings: Vec<MidiMapping>,
 }
 
-impl Config {
-    pub fn new() -> Config {
-        Config {
-            midi_mappings: vec![],
-        }
-    }
-}
-
 #[derive(Debug, PartialEq)]
 pub enum DataValue {
     Any,
@@ -105,7 +98,7 @@ impl DataValue {
             }
         }
 
-        let split: Vec<u8> = s.split("-").filter_map(|s| u8::from_str(s).ok()).collect();
+        let split: Vec<u8> = s.split('-').filter_map(|s| u8::from_str(s).ok()).collect();
 
         if split.len() == 2 && split[0] <= 127 && split[1] <= 127 && split[0] < split[1] {
             return Some(DataValue::Range(split[0], split[1]));
@@ -180,7 +173,7 @@ impl MidiMapping {
                 u8::from_str(c)
                     .map_err(|_| "Channel must be * or a number".to_string())
                     .and_then(|c| {
-                        if c >= 1 && c <= 16 {
+                        if (1..=16).contains(&c) {
                             Ok(c)
                         } else {
                             Err("Channel must be between 1 and 16".to_string())

diff --git a/loopers-common/src/gui_channel.rs b/loopers-common/src/gui_channel.rs
@@ -65,14 +65,15 @@ pub enum GuiCommand {
     AddGlobalTrigger(FrameTime, Command),
 }
 
-#[derive(Clone)]
+#[derive(Clone, Default)]
 pub enum LogLevel {
+    #[default]
     Info,
     Warn,
     Error,
 }
 
-#[derive(Clone)]
+#[derive(Clone, Default)]
 pub struct LogMessage {
     buffer: ArrayVec<u8, 256>,
     len: usize,
@@ -81,14 +82,6 @@ pub struct LogMessage {
 }
 
 impl LogMessage {
-    pub fn new() -> Self {
-        LogMessage {
-            buffer: ArrayVec::new(),
-            len: 0,
-            level: LogLevel::Info,
-        }
-    }
-
     pub fn error() -> Self {
         LogMessage {
             buffer: ArrayVec::new(),
@@ -131,7 +124,7 @@ impl GuiSender {
 
         let sender = GuiSender {
             cmd_channel: Some(tx),
-            cur_message: LogMessage::new(),
+            cur_message: LogMessage::default(),
             log_channel: Some(log_tx),
         };
 
@@ -146,7 +139,7 @@ impl GuiSender {
     pub fn disconnected() -> GuiSender {
         GuiSender {
             cmd_channel: None,
-            cur_message: LogMessage::new(),
+            cur_message: LogMessage::default(),
             log_channel: None,
         }
     }
@@ -165,7 +158,7 @@ impl GuiSender {
         }
     }
 
-    pub fn send_log(&mut self, message: LogMessage) -> () {
+    pub fn send_log(&mut self, message: LogMessage) {
         if let Err(e) = self.send_log_with_result(message) {
             warn!("Failed to send message to gui: {}", e);
         }

diff --git a/loopers-common/src/music.rs b/loopers-common/src/music.rs
@@ -82,10 +82,10 @@ mod tests {
         let next_beat_time = tempo.next_full_beat(FrameTime(time));
 
         assert!(
-            next_beat_time.0 <= time + frames as i64,
+            next_beat_time.0 <= time + frames,
             "{} > {} (time = {})",
             next_beat_time.0,
-            time + frames as i64,
+            time + frames,
             time
         );
 
@@ -143,9 +143,7 @@ pub struct Tempo {
 impl Tempo {
     pub fn new(bpm: u64) -> Tempo {
         assert!(bpm > 0, "bpm must be positive");
-        Tempo {
-            bpm
-        }
+        Tempo { bpm }
     }
 
     pub fn from_bpm(bpm: f32) -> Tempo {
@@ -192,17 +190,17 @@ impl SavedMetricStructure {
     pub fn to_ms(&self) -> Result<MetricStructure, String> {
         let bpm = match self.tempo {
             SavedTempo { bpm: Some(bpm), .. } => Ok(Tempo::new(bpm)),
-            SavedTempo { samples_per_beat: Some(spb), ..} =>
-                Ok(Tempo::from_bpm(
-                    ((get_sample_rate() as f64) / spb as f64 * 60.0) as f32)),
-            _ => Err("Neither bpm nor samples_per_beat supplied".to_string())
+            SavedTempo {
+                samples_per_beat: Some(spb),
+                ..
+            } => Ok(Tempo::from_bpm(
+                ((get_sample_rate() as f64) / spb as f64 * 60.0) as f32,
+            )),
+            _ => Err("Neither bpm nor samples_per_beat supplied".to_string()),
         }?;
 
-        MetricStructure::new(
-            self.time_signature.upper,
-            self.time_signature.lower,
-            bpm,
-        ).ok_or("Invalid time signature".to_string())
+        MetricStructure::new(self.time_signature.upper, self.time_signature.lower, bpm)
+            .ok_or("Invalid time signature".to_string())
     }
 }
 

diff --git a/loopers-engine/Cargo.toml b/loopers-engine/Cargo.toml
@@ -12,18 +12,18 @@ license = "MIT OR Apache-2.0"
 crossbeam-queue = "0.3"
 crossbeam-channel = "0.5"
 crossbeam-utils = "0.8"
-atomic = "0.5.0"
+atomic = "0.6.0"
 rand = "0.8"
-hound = "3.4.0"
-chrono = "0.4.11"
+hound = "3.5.0"
+chrono = "0.4.31"
 lazy_static = "1.4.0"
 bytes = "1.0"
-futures = "0.1"
-dirs = "4"
+futures = "0.3"
+dirs = "5"
 log = "0.4"
-toml = "0.5"
+toml = "0.8"
 serde_json = "1.0"
-itertools = "0.10"
+itertools = "0.12"
 
 [dependencies.loopers-common]
 path = "../loopers-common"