Jack transport #29
Draft
Jack transport #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philipp Mildenberger <philipp@mildenberger.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on top of #28, which is the reason for the large amount of changes (last two commits are relevant, I'll rebase this onto master, when #28 is merged)
This adds fairly complete jack transport support (no sync yet though), based on the original
jack_transportbranch, as timebase master (maybe we should support this optionally in the future).This means:
jack_set_timebase_callback, which updates the jack transport position, or sets the engine time to a new requested position (viaengine.time = jack::TransportPosition::frame())This is currently implemented via an
Arc<Mutex<Engine>>. I originally wanted to use 2 channels (set and gettime/metric_structure, but I think it's actually simpler to just use aMutexaround the engine instead.