Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle inputs and ouputs #228

Merged
merged 62 commits into from
Aug 22, 2023
Merged

feat: handle inputs and ouputs #228

merged 62 commits into from
Aug 22, 2023

Conversation

JeremyPansier
Copy link
Member

@JeremyPansier JeremyPansier commented Apr 21, 2023 •
edited
Loading

Checklist:

  • The code follows our code conventions.
  • Important principle changes have been documented in the wiki.
  • The new code is covered by unit tests with assertions.
  • The behaviour node and UI have been manually tested and is as expected.
  • The squash commit message follows our conventions.

@JeremyPansier
add wallet
d2baf46
@JeremyPansier
add inputs and outputs (doesn't compile)
778dbb5
@JeremyPansier
update utxos (doesn't compile)
ac853d8
@JeremyPansier
fix node
9dbc2cb
@JeremyPansier
blockchain validation fixed
2972571
@JeremyPansier
simplify timestamp
9e1b8ac
@JeremyPansier
fix UI (tx ID not parsed yet)
d430409
@JeremyPansier
clean (await ajax missing)
219af36
@JeremyPansier
fix await (verify signature fails)
daa0477
@JeremyPansier
fix signature verification (add transaction takes too much time)
e6b42c0
@JeremyPansier
fix add transaction too slow (index out of range error)
2f9f030
@JeremyPansier
fix add transaction too slow (index out of range error)
1ffde0d
@JeremyPansier
fix fee
9966cf5
@JeremyPansier
change transaction id type to string
6680eb7
@JeremyPansier
fix add transaction
35a2fb5
@JeremyPansier
add only positive utxos
c350707
@JeremyPansier
fix nil utxo
6100aab
@JeremyPansier
hide password
abcb2e3
@JeremyPansier
overlap password field with checkbox
ba20266
@JeremyPansier
manage has income on ui
44c1dac
@JeremyPansier
improve button look
c00923d
@JeremyPansier
fix duplicated utxos (hash issue)
5a0cb96
@JeremyPansier
fix different hash for same block (fee issue)
aaa3343
@JeremyPansier
fix fee
edb9ef9
@JeremyPansier
fix genesis timestamp (first block timestamp sometimes is wrong)
9b4a525
@JeremyPansier
fi ui genesis timestamp
22f245c
@JeremyPansier
fix out of bounds
b536ea4
@JeremyPansier
fix new registered addresses
5d15d6c
@JeremyPansier
fix registered transaction
64af1a2
@JeremyPansier
fix most of unit tests
aa47dfa
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

80.8% 80.8% Coverage
0.0% 0.0% Duplication

@JeremyPansier JeremyPansier merged commit e8df1bc into release/4.0.0 Aug 22, 2023
8 checks passed
@JeremyPansier JeremyPansier deleted the 221-handle-inputs-and-ouputs branch August 22, 2023 17:04
This was linked to issues Aug 25, 2023
Blocks requests are not parallelized #131
Closed
Store UTXOs and registered wallet balances #224
Closed
Calculate non registered wallet balances using UTXOs #225
Closed
JeremyPansier added a commit that referenced this pull request Sep 15, 2023
@JeremyPansier
feat: handle inputs and ouputs (#228)
5ca3390 
BREAKING CHANGE: Node and UI APIs have changed.
1. Both Node and UI
* Added:
  - The data structure for input:
  Input {
    OutputIndex   uint16
    TransactionId string
    PublicKey     string
    Signature     string
  }
  - The data structure for output:
  Output {
    Address   string
    HasReward bool
    HasIncome bool
    Value     uint64
  }
* Modified:
  - The transaction data structure for response was:
  TransactionResponse {
    RecipientAddress string
    SenderAddress    string
    SenderPublicKey  string
    Signature        string
    Timestamp        int64
    Value            uint64
    Fee              uint64
  }
  - The transaction data structure for response is:
  TransactionResponse {
    Id        string
    Inputs    []*InputResponse
    Outputs   []*OutputResponse
    Timestamp int64
  }
2. Node
* Added:
  - Endpoint: Get block
  - Endpoint: Get UTXOs
* Removed:
  - Endpoint: Get amount
* Modified:
  - The data structure for target request was:
  TargetRequest {
    Ip   string
    Port uint16
  }
  - The data structure for target request is:
  TargetRequest {
    Ip   string
  }
  - The data structure for transaction request was:
  TransactionRequest {
    Fee                          uint64
    RecipientAddress             string
    SenderAddress                string
    SenderPublicKey              string
    Signature                    string
    Timestamp                    int64
    TransactionBroadcasterTarget string
    Value                        uint64
  }
  - The data structure for transaction request is:
  TransactionRequest {
    Inputs                       []InputRequest
    Outputs                      []OutputRequest
    Timestamp                    int64
    TransactionBroadcasterTarget string
  }
3. UI
* Added:
  - Endpoint: GET transaction/info
* Modified:
  - The data structure for transaction request was:
  TransactionRequest {
    Fee                          uint64
    RecipientAddress             string
    SenderAddress                string
    SenderPublicKey              string
    Signature                    string
    Timestamp                    int64
    Value                        uint64
  }
  - The data structure for transaction request is:
  TransactionRequest {
    Inputs    []InputRequest
    Outputs   []OutputRequest
    Timestamp int64
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JeremyPansier