-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[actions] CI on JDK 22 #2939
[actions] CI on JDK 22 #2939
Conversation
harawata
commented
Aug 22, 2023
- 21 reaches RC
- 22 EA is available
- 21 reaches RC - 22 EA is available
pom.xml
Outdated
@@ -153,6 +153,8 @@ | |||
|
|||
<!-- Reproducible Builds --> | |||
<project.build.outputTimestamp>1678513628</project.build.outputTimestamp> | |||
|
|||
<allowed.build.jdks>[11,12),[17,18),[20,21),[21,23)</allowed.build.jdks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harawata Did you mean 22,23 in the last spot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask you, actually.
I copied the following line from the parent which has [20,21),[21,22)
and modified it so that the build can run on 22.
https://github.com/mybatis/parent/blob/master/pom.xml#L267
Are you suggesting to use [11,12),[17,18),[20,21),[22,23)
?
That would exclude 21 which is LTS version, so it does not seem right.
https://www.oracle.com/java/technologies/java-se-support-roadmap.html
Entry for both 21 and 22 separately in same style. Mainly to block the version as at some point it's easier to drop older ones out.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Iwao AVE! ***@***.***>
Sent: Friday, August 25, 2023 6:02:09 AM
To: mybatis/mybatis-3 ***@***.***>
Cc: Jeremy Landis ***@***.***>; Mention ***@***.***>
Subject: Re: [mybatis/mybatis-3] [actions] CI on JDK 22 (PR #2939)
@harawata commented on this pull request.
________________________________
In pom.xml<#2939 (comment)>:
@@ -153,6 +153,8 @@
<!-- Reproducible Builds -->
<project.build.outputTimestamp>1678513628</project.build.outputTimestamp>
+
+ <allowed.build.jdks>[11,12),[17,18),[20,21),[21,23)</allowed.build.jdks>
@hazendaz<https://github.com/hazendaz> ,
I was going to ask you, actually.
I copied the following line from the parent which has [20,21),[21,22) and modified it so that the build can run on 22.
https://github.com/mybatis/parent/blob/master/pom.xml#L267
Are you suggesting to use [11,12),[17,18),[20,21),[22,23) ?
That would exclude 21 which is LTS version, so it does not seem right.
https://www.oracle.com/java/technologies/java-se-support-roadmap.html
—
Reply to this email directly, view it on GitHub<#2939 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI34CANNSREN2PRLAJ3XXBZ2DANCNFSM6AAAAAA32F6JNQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Got it! |