Fix SSD1306 #519
Open
Fix SSD1306 #519
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, just to double check, is this related to which issue? Is #511 (merged into development recently) still not enough? Thanks! |
|
Hi, I didn't create an issue for this. It was a compile error when I was compiling for ESP8266 - then the ifdef in NodeManager/sensors/DisplaySSD1306.h Line 136 in 7fbf28a NodeManager/sensors/DisplaySSD1306.h Line 139 in 7fbf28a _oled field is of type SSD1306AsciiWire, which is not a SSD1306AsciiAvrI2c as expected by getDisplay() signature. SSD1306Ascii is a common and direct ancestor of both classes.
|
|
Oh understand, thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fix works for me.