Advanced filters and New homepage layout #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascumsille
force-pushed
the
694-v3-advanced-filters
branch
from
a3e497f to
4ed4fb3
Compare
lucascumsille
force-pushed
the
694-v3-advanced-filters
branch
2 times, most recently
from
cede212 to
716fd59
Compare
-Added .section-title class to replace all the extra bootstrap classes, that overcomplicate things when changing elements in home and home CA
This fix gets rid of the warning message on the console.
lucascumsille
force-pushed
the
694-v3-advanced-filters
branch
from
716fd59 to
8e57d6e
Compare
lucascumsille
changed the title
1 task
Rather than having an element that reads out which advanced filters are active (which we’d already temporarily hidden because we were worried it was just too much clutter) and a "reset" button, this commit introduces very obvious styling for advanced filter `<select>` elements when they have been modified. This should make it clear which filters a user has selected, and therefore also easier to quickly reset them manually back to the Any/All option. The active filters are styled up to match the active buttons above, for consistency. I also made the advanced filter select boxes slightly smaller, to match the size of the Country buttons on the Single Tier scorecard.
zarino
force-pushed
the
694-v3-advanced-filters
branch
from
dca62be to
fdb2ffa
Compare
zarino
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #694
Preview:
Screen.Recording.2024-11-18.at.06.49.47.mov