Upgrade Stripe library/API version to current #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
approved these changes
Jun 12, 2024
dracos
force-pushed
the
stripe-upgrade
branch
4 times, most recently
from
bd82074
to
6e894f0
Compare
dracos
force-pushed
the
master
branch
3 times, most recently
from
2c2b1cc
to
ccc444c
Compare
|
https://github.com/mysociety/theyworkforyou/tree/stripe-upgrade-format < should be this but via the new formatting. |
|
Thanks, my ignorance on previous comment! |
dracos
force-pushed
the
stripe-upgrade
branch
from
6e894f0
to
387bf32
Compare
dracos
force-pushed
the
stripe-upgrade
branch
from
387bf32
to
cec37bb
Compare
-$subscription->stripe->cancel(['at_period_end' => true]);
+\Stripe\Subscription::update($subscription->stripe->id, ['cancel_at_period_end' => false]);true somehow became false here (in my original changes) |
2018-08-23 - delete() only for instant deletion now 2018-11-08 - invoice status, rather than forgiven boolean 2019-10-17 - account_balance renamed to balance 2020-08-27 - supply tax rate ID rather than tax_percent 2023-08-16 - state we allow automatic payment methods, but no redirect
Use the new Subscription Schedules so that downgrade will only apply from the next billing period.
You cannot cancel a subscription with a schedule.
dracos
force-pushed
the
stripe-upgrade
branch
from
cec37bb
to
370651f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar (hopefully identical?) to mysociety/mapit.mysociety.org#158
so we can get on current Stripe API version, and improve downgrade behaviour.