Update queries to better match pw export #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PW export had more info on debate gids, and memberships
dracos
reviewed
Jul 25, 2024
| ON persondivisionvotes.division_id = divisions.division_id | ||
| JOIN member | ||
| ON persondivisionvotes.person_id = member.person_id | ||
| AND divisions.division_date BETWEEN member.entered_house AND member.left_house; |
There was a problem hiding this comment.
This will have an issue if someone is in two houses at once, that both have divisions, won't it?
There was a problem hiding this comment.
Ah right - it needs to also have a divisions.house = member.house I think? I'll give that a go at some point and check it outputs correctly.
There was a problem hiding this comment.
Ok, fix in a new commit which I'll squish. divisions.house is string and member.house is int so it needs the conversion in the query. Adding this slightly decreased the number of divisions being exported as you'd hope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the export for twfy-votes to more closely mirror the original public whip data table dumps.