Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing metadata #1399

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Handle missing metadata #1399

merged 4 commits into from
Nov 22, 2023

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Nov 21, 2023

Solve #1398

@bgrainger
Copy link
Member

Thanks; I think this makes sense to accommodate a "truncated" packet sent from the server as though it doesn't actually support MARIADB_CLIENT_CACHE_METADATA. (A packet capture to show exactly what's going on would still be interesting.)

Do you agree that these contributions are made under the terms of https://developercertificate.org/? (I can set that check to pass.)

@trejjam
Copy link
Contributor Author

trejjam commented Nov 21, 2023

ToC approve

@trejjam
Copy link
Contributor Author

trejjam commented Nov 21, 2023

mysql-missing-metadata.zip

@bgrainger bgrainger merged commit 4439754 into mysql-net:master Nov 22, 2023
22 checks passed
@bgrainger bgrainger mentioned this pull request Nov 22, 2023
Closed
@trejjam trejjam deleted the feature/handle-missing-metadata branch November 22, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trejjam @bgrainger