New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in hkdf_expand #5

Open

joerowell wants to merge 1 commit into n-for-1-auth:main from joerowell:main

joerowell commented Nov 15, 2022 •

edited

Loading

At the moment hkdf_expand allocates memory on each iteration of the loop but never frees it:

for(int i = 1; i <= N; i++) {
    auto input = new block[8 + info_len + cur_T_len];
    ...
}

This means that the program leaks memory each time hkdf_expand is called.

This PR fixes this by:

Moving the allocation outside of the loop. This should also make the code run faster.
Freeing the memory after the loop terminates.


          Fix memory leak.

35135df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet