Skip to content

Commit

Permalink
chore: (Deps) Update swarm-discovery to avoid idna <= 0.5 dep (#3025)
Browse files Browse the repository at this point in the history
## Description

<!-- A summary of what this pull request achieves and a rough list of
changes. -->
- Updates to latest `swarm-discovery` alpha, so that `cargo deny` is
happy again

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->
None, swarm-discovery isn't exposed in the API.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->
It might be questionable if we want to depend on *more* alphas, but
IMHO, this case is fine to avoid a security vulnerability.
Hopefully this is the last alpha. The next version of hickory we depend
on should be 0.25.

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.~~
- ~~[ ] Tests if relevant.~~
- [x] All breaking changes documented.
  • Loading branch information
matheus23 authored Dec 10, 2024
1 parent 9f4ca84 commit 095fcc7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 50 deletions.
56 changes: 8 additions & 48 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,4 @@ license-files = [{ path = "LICENSE", hash = 0xbd0eed23 }]
ignore = [
"RUSTSEC-2024-0370", # unmaintained, no upgrade available
"RUSTSEC-2024-0384", # unmaintained, no upgrade available
"RUSTSEC-2024-0421", # dependency from swarm-discovery, see https://github.com/rkuhn/swarm-discovery/issues/9
]
2 changes: 1 addition & 1 deletion iroh/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ net-report = { package = "iroh-net-report", path = "../iroh-net-report", version
iroh-metrics = { version = "0.29", default-features = false }

# local-swarm-discovery
swarm-discovery = { version = "0.2.1", optional = true }
swarm-discovery = { version = "0.3.0-alpha.1", optional = true }

# dht_discovery
genawaiter = { version = "0.99", features = ["futures03"], optional = true }
Expand Down

0 comments on commit 095fcc7

Please sign in to comment.