Skip to content

Commit

Permalink
chore: bump netsim setup (#3004)
Browse files Browse the repository at this point in the history
## Description

The sims on `netsim` have been promoted and are replacing the old ones.
PRs older than 2 weeks from main no longer work with netsim. A simple
rebase should fix it where necessary. I'll leave this as is for another
2 weeks and then do the cleanup pass.

This has the neat benefit of also dropping old fixture generation
scripts which should drop netsim execution time by ~1 min.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
  • Loading branch information
Arqu authored Dec 4, 2024
1 parent b2b070f commit a3f0497
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ jobs:
branch: ${{ github.ref }}
max_workers: 4
netsim_branch: "main"
sim_paths: "sims/iroh_v2/iroh.json,sims/integration_v2"
sim_paths: "sims/iroh/iroh.json,sims/integration"
pr_number: ${{ github.event.pull_request.number || '' }}

codespell:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/netsim.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
branch: "main"
max_workers: 1
netsim_branch: "main"
sim_paths: "sims/iroh_v2,sims/integration_v2"
sim_paths: "sims/iroh,sims/integration"
pr_number: ""
publish_metrics: true
build_profile: "optimized-release"
Expand All @@ -53,7 +53,7 @@ jobs:
branch: ${{inputs.branch}}
max_workers: 1
netsim_branch: ${{inputs.netsim_branch}}
sim_paths: "sims/iroh_v2"
sim_paths: "sims/iroh"
pr_number: ${{inputs.pr_number}}
publish_metrics: false
build_profile: "optimized-release"
Expand Down

0 comments on commit a3f0497

Please sign in to comment.