Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move iroh-router into iroh-net and rename iroh-net to iroh #2973

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

matheus23
Copy link
Contributor

@matheus23 matheus23 commented Nov 28, 2024

Description

This merges iroh-net, iroh-router and iroh into simply one crate: iroh.

Also adjusts README and documentation messages.

Breaking Changes

  • iroh-net got renamed to iroh
  • iroh-router moved into iroh
  • iroh-router::ProtocolHandler is now iroh::protocol::ProtocolHandler
  • iroh-router::ProtocolMap is now iroh::protocol::ProtocolMap
  • iroh-router::Router is now iroh::router::Router
  • iroh-router::RouterBuilder is now iroh::router::RouterBuilder

Notes & open questions

Minor Q: Do the iroh::protocol and iroh::router modules make sense?

Change checklist

  • Fix "TODO(matheus23): docs" for Router etc.
  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link

github-actions bot commented Nov 28, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2973/docs/iroh/

Last updated: 2024-11-28T11:21:42Z

Copy link

github-actions bot commented Nov 28, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: cc81ff0

@dignifiedquire dignifiedquire added this pull request to the merge queue Nov 28, 2024
@dignifiedquire dignifiedquire added this to the v0.29.0 milestone Nov 28, 2024
Merged via the queue into main with commit f7764ef Nov 28, 2024
25 of 26 checks passed
@matheus23 matheus23 deleted the matheus23/one-iroh branch November 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants