Raul h #1
Open
Raul h #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a "final commit"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI John and Florian ,
Here I submit my coding task finally completed. I apologise for the delay, but with the beginning of the new project and the spikes we are having, it wasn't the easiest to find the time to complete the task while trying to catch up.
That leads me to the testing part. If you have a look to the two I wrote, specially one of them is kind of dumb. In my defense I'd say that I've never done one before, and testing wasn't inside scope of the previous projects, so in this short time I just could read a bit about them and trying to implement the easiest version of one.
But thanks to this, I convinced the mentors to include it in the scope of this last project, and we will be having a spike about them in coming weeks. So thank you :)
I'd also like to point out that now the loading progress bar it is behaving realistically, by using the updated data coming from the parallelUploads3 object from amazon. During the interview, since the upload function wasn't still working, it was just set with an initial and final value.
Last but not least, I just wanted to thank you the opportunity, regardless of the outcome. It is being a great learning experience for me.
Best regards,
Raul.