Rework TaskController

config/rbac/role-workflow-manager.yaml

@@ -8,6 +8,8 @@ rules:
   - ""
   resources:
   - configmaps
+  - secrets
+  - services
   verbs:
   - create
   - delete
@@ -23,16 +25,6 @@ rules:
   verbs:
   - create
   - patch
-- apiGroups:
-  - ""
-  resources:
-  - secrets
-  verbs:
-  - create
-  - delete
-  - get
-  - patch
-  - update
 - apiGroups:
   - batch
   resources:

internal/pkg/apis/utils/names.go

@@ -0,0 +1,40 @@
+/*
+Copyright 2022-2024 The nagare media authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package utils
+
+import (
+	"fmt"
+
+	utilrand "k8s.io/apimachinery/pkg/util/rand"
+)
+
+// Adopted from:
+// https://github.com/kubernetes/apiserver/blob/cccad306d649184bf2a0e319ba830c53f65c445c/pkg/storage/names/generate.go
+// Copyright 2014 The Kubernetes Authors. Apache-2.0 license.
+
+const (
+	maxNameLength          = 63
+	randomLength           = 5
+	maxGeneratedNameLength = maxNameLength - randomLength - 1
+)
+
+func GenerateName(base string) string {
+	if len(base) > maxGeneratedNameLength {
+		base = base[:maxGeneratedNameLength]
+	}
+	return fmt.Sprintf("%s-%s", base, utilrand.String(randomLength))
+}

internal/pkg/engineurl/types.go

@@ -33,6 +33,10 @@ const (
 
 type URL string
 
+func IsEngineURL(u string) bool {
+	return strings.HasPrefix(u, NagareEngineScheme+"://")
+}
+
 func Parse(u string) (ParsedURL, error) {
 	url := URL(u)
 	return url.Parse()