Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error cascade #76

Closed
wants to merge 7 commits into from
Closed

Error cascade #76

wants to merge 7 commits into from

Conversation

xxxserxxx
Copy link
Contributor

This version (which can be merged on top of, or instead of, report_errors) replaces ExitFail() in the top-level functions, such that errors are passed up to the main function and reported there. Long-term, ExitFail() would ideally be removed entirely; by exiting deep in the stack, it prevents calling functions the opportunity to handle and clean up after errors. However, this PR focuses on having consistent behavior in all of the top-level commands by using RunE() wherever there can be failures.

…allowing for the opportunity of better state clean-up.
@xxxserxxx
Copy link
Contributor Author

xxxserxxx commented Aug 12, 2022

All of these PRs are based on different branches, and they often conflict. If you're going to pull any of them, I recomend pulling issue-69 and user-keys-master first, then letting me know which others you do (or don't) want to merge, and letting me resolve the conflicts.

@naggie
Copy link
Owner

naggie commented Sep 13, 2022

Thanks @xxxserxxx -- I will get the user-keys-master branch merged first I think. A useful change and helps @botto 's plight of separating the cli into a lib. @botto please take a look too.

@xxxserxxx
Copy link
Contributor Author

Rebased naggie/master onto this so it's a clean merge again.

@naggie
Copy link
Owner

naggie commented Aug 9, 2024

@xxxserxxx would you mind resolving the build issue here pls? Feel free to revert my bad merge.

@xxxserxxx
Copy link
Contributor Author

@xxxserxxx would you mind resolving the build issue here pls? Feel free to revert my bad merge.

Yah, no problem.

@xxxserxxx
Copy link
Contributor Author

Man, I hate git.

I created a new branch, error_cascade_clean, that I'll open a new PR for.

@xxxserxxx xxxserxxx closed this Aug 13, 2024
@xxxserxxx xxxserxxx mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants