Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load diff for inspection #6

Draft
wants to merge 7 commits into
base: nagilson-global-sdk-install
Choose a base branch
from

Conversation

nagilson
Copy link
Owner

@nagilson nagilson commented Aug 3, 2023

No description provided.

nagilson added 7 commits July 21, 2023 15:32
…hich causes every command on the sample extension to fail
The sample extension needs a license to be packed without warning, so I copied the license over to its folder

The debugging has a prototype logger to log to a C: log file. It still needs more testing.
newer versions of p-retry use es6 syntax vscode doesnt support, so it will fail to run
we had to downgrade it

we also added to the output stream observer to try to get vscode to output debug messages
the registry key lookup was not working on 32 bit machines
node could not resolve system root
the install location was different than I expected
and the registry keys are stored in a different location
in addition, during refactor for the linter I forgot to remove the ' in one of the strings causing failure

todo: see on win32 why an existing install does not return 0. It might be because of the reg key error
@nagilson nagilson marked this pull request as draft August 3, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant