fix(types): relax the type of c.req.param() (honojs#2613)

* fix(types): relax the type of `c.req.param()` * denoify
nakasyou · May 5, 2024 · cb24160 · cb24160
1 parent a900fbe
commit cb24160
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/deno_dist/request.ts b/deno_dist/request.ts
@@ -79,6 +79,7 @@ export class HonoRequest<P extends string = '/', I extends Input['out'] = {}> {
   param<P2 extends RemoveQuestion<ParamKeys<P>> = RemoveQuestion<ParamKeys<P>>>(
     key: P2
   ): string | undefined
+  param(key: string): string | undefined
   param<P2 extends string = P>(): UnionToIntersection<ParamKeyToRecord<ParamKeys<P2>>>
   param(key?: string): unknown {
     return key ? this.getDecodedParam(key) : this.getAllDecodedParams()

diff --git a/src/hono.test.ts b/src/hono.test.ts
@@ -856,8 +856,6 @@ describe('param and query', () => {
   describe('param with undefined', () => {
     const app = new Hono()
     app.get('/foo/:foo', (c) => {
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      /* @ts-ignore */
       const bar = c.req.param('bar')
       return c.json({ foo: bar })
     })

diff --git a/src/request.ts b/src/request.ts
@@ -79,6 +79,7 @@ export class HonoRequest<P extends string = '/', I extends Input['out'] = {}> {
   param<P2 extends RemoveQuestion<ParamKeys<P>> = RemoveQuestion<ParamKeys<P>>>(
     key: P2
   ): string | undefined
+  param(key: string): string | undefined
   param<P2 extends string = P>(): UnionToIntersection<ParamKeyToRecord<ParamKeys<P2>>>
   param(key?: string): unknown {
     return key ? this.getDecodedParam(key) : this.getAllDecodedParams()