Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds refresh logic when one connection is expired #689

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jaypalmudaliyar24
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/db-expired-connection branch 3 times, most recently from a9a353f to b3f4a96 Compare December 3, 2024 08:48
@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/db-expired-connection branch 7 times, most recently from 3842211 to bdcb174 Compare December 17, 2024 09:41
@jaypalmudaliyar24 jaypalmudaliyar24 marked this pull request as ready for review December 17, 2024 09:45
"owner": "nammayatri",
"repo": "euler-hs",
"rev": "dfe2249ca40fbee35b772eaa937c762498309312",
"rev": "bccffdbc6c27e9ed648a1abb95f288763cff6bcc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like wrong commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are pointing to this branch currently in main.
https://github.com/nammayatri/euler-hs/commits/backend/logging-latency/

@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/db-expired-connection branch from bdcb174 to 91f0125 Compare December 17, 2024 13:21
@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/db-expired-connection branch from 91f0125 to c76be33 Compare December 17, 2024 13:23
@arjuna92 arjuna92 merged commit a6db5a2 into main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants