Feature/unmrashall #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLieutenant
requested changes
Oct 19, 2023
types/types.go
Outdated
| @@ -89,6 +90,22 @@ func (o *NullBool) UnmarshalBSONValue(t bsontype.Type, bytes []byte) error { | |||
|
|
|||
| return nil | |||
| } | |||
| func (o *NullBool) JSONUnmarshal(data []byte) error { | |||
There was a problem hiding this comment.
name of the method UnmarshalJSON -> implements json.Unmarshaler
types/types.go
Outdated
| @@ -89,6 +90,22 @@ func (o *NullBool) UnmarshalBSONValue(t bsontype.Type, bytes []byte) error { | |||
|
|
|||
| return nil | |||
| } | |||
| func (o *NullBool) JSONUnmarshal(data []byte) error { | |||
| if len(data) <= 0 { | |||
There was a problem hiding this comment.
can be just == 0, but also need to handle the case of "null" in bytes
if len(data) == 0 || bytes.Compare(jsonNullBytes, data) == 0 {
// value is true JSON null
types/types.go
Outdated
| return nil | ||
| } | ||
|
|
||
| var isTrue bool |
There was a problem hiding this comment.
for simple types such as JSON boolean, there are only two possible values, we can make a happy path
switch(utils.UnsafeString(data) {
case "true":
case "false"
default:
// Fall back to JSON marshaler to the thing
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 31.88% 31.54% -0.34%
==========================================
Files 24 24
Lines 1700 1718 +18
==========================================
Hits 542 542
- Misses 1117 1135 +18
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
CodeLieutenant
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.