Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/grpc dns resolver #23

Merged
merged 8 commits into from
May 10, 2024
Merged

Feat/grpc dns resolver #23

merged 8 commits into from
May 10, 2024

Conversation

CodeLieutenant
Copy link
Collaborator

No description provided.

Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
@CodeLieutenant CodeLieutenant self-assigned this May 10, 2024
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 30.03%. Comparing base (b05b05f) to head (67be99a).

Files Patch % Lines
grpc/resolvers/dns_resolver.go 66.46% 43 Missing and 12 partials ⚠️
types/types.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   30.91%   30.03%   -0.88%     
==========================================
  Files          26       31       +5     
  Lines        1876     1881       +5     
==========================================
- Hits          580      565      -15     
- Misses       1248     1256       +8     
- Partials       48       60      +12     
Flag Coverage Δ
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeLieutenant CodeLieutenant merged commit ea045ae into master May 10, 2024
2 of 5 checks passed
@CodeLieutenant CodeLieutenant deleted the feat/grpc-dns-resolver branch May 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants