Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of online_reps class #4656

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

pwojcikdev
Copy link
Contributor

This is an overhaul of online_reps class:

  • Run periodic online weight sampling on a dedicated thread, which makes it more robust and easier to debug.
  • Eliminate use of store.online_weight.count () and erasing entries based on their timestamps instead (2 weeks for live, 1 day for beta).
  • Add stats and logging to improve observability.
  • Add asserts to ensure data consistency.
  • Split and rewrite functions, so they are (subjectively) cleaner.
  • Ensure that nano::online_reps::trended () can never return value lower than the limit configured via online_weight_minimum.

@pwojcikdev pwojcikdev force-pushed the online-reps-overhaul branch from 81d6990 to 20a6241 Compare June 26, 2024 10:39
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jun 26, 2024
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jun 26, 2024
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jun 26, 2024
@qwahzi qwahzi added this to the V27 milestone Jul 1, 2024
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jul 7, 2024
clemahieu
clemahieu previously approved these changes Jul 15, 2024
@qwahzi qwahzi modified the milestones: V27, V26.0, V28 Jul 23, 2024
@pwojcikdev pwojcikdev force-pushed the online-reps-overhaul branch 2 times, most recently from c064dba to 0294673 Compare December 20, 2024 18:44
@gr0vity-dev-bot
Copy link

gr0vity-dev-bot commented Dec 21, 2024

Test Results for Commit 56395a6

Pull Request 4656: Results
Overall Status:

Test Case Results

  • 5n4pr_conf_10k_bintree: PASS (Duration: 118s)
  • 5n4pr_conf_10k_change: PASS (Duration: 135s)
  • 5n4pr_conf_change_dependant: FAIL (Duration: 1580s)
  • Log
  • 5n4pr_conf_change_independant: PASS (Duration: 134s)
  • 5n4pr_conf_send_dependant: PASS (Duration: 126s)
  • 5n4pr_conf_send_independant: PASS (Duration: 129s)
  • 5n4pr_rocks_10k_bintree: PASS (Duration: 114s)
  • 5n4pr_rocks_10k_change: PASS (Duration: 164s)

Last updated: 2024-12-23 12:30:41 UTC

@pwojcikdev pwojcikdev force-pushed the online-reps-overhaul branch 2 times, most recently from 11f67eb to 444f76d Compare December 22, 2024 17:59
@pwojcikdev pwojcikdev merged commit 60a44d6 into nanocurrency:develop Dec 23, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged / V28.0
Development

Successfully merging this pull request may close these issues.

4 participants