New features to support TigerBeetle #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socket read/write operations can be trigggered asynchronously, e.g. via io_uring; thus, the context to be associated to the blockq for a read/write operation may not be the current context; instead, this context must be retrieved from the closure that is created when triggering the operation. In addition, in the blockq_check_timeout() function the `blocked_on` field of the unix_context struct must be set regardless of whether the operation is synchronous.
Change the prototype of the accept4, sendto and recvfrom callback functions in the socket structure (and their implementation in the network, Unix, netlink and vsock socket types) to take additional parameters that will allow these functions to be called when triggering an asynchronous operation (e.g. via io_uring).
This function will be reused when implementing non-read/write asynchronous operations.
The newly added rlimit_stack field in the process struct holds the current value of the stack limit.
Instead of hardcoding file permission bits, retrieve them from the file metadata. With this change, the execute permission bit is set when the user program invokes stat() on the executable file; this is required in order to avoid "BinaryNotMarkedExecutable" errors when running tigerbeetle (https://github.com/tigerbeetle/tigerbeetle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set implements new features that allow running TigerBeetle (https://github.com/tigerbeetle/tigerbeetle) on Nanos: