Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build on RN 0.32 (LoadImageWithTag removed) #57

Open
samuelkraft opened this issue Aug 29, 2016 · 5 comments
Open

Can't build on RN 0.32 (LoadImageWithTag removed) #57

samuelkraft opened this issue Aug 29, 2016 · 5 comments

Comments

@samuelkraft
Copy link

LoadImageWithTag was deprecated a while ago and removed with rn 0.32. It is now not possible to build with Xcode anymore.

@ammichael
Copy link

ammichael commented Sep 15, 2016

No workaround yet?
I need to send an update to the store, and this is the only lib I can't get to work

Edit:
Nevermind. Here: https://github.com/naoufal/react-native-activity-view/pull/56/files

@ismdcf
Copy link

ismdcf commented Sep 23, 2016

thnks @ammichael but now I get the following error

Exception '-[__NSCFString _setProperty:forKey:]: unrecognized selector sent to instance 0x7fd9615b8ab0' was thrown while invoking show on target ActivityView with params ( { imageUrl = "<imagelink>"; text = "<sample text>"; } )
using RN 0.33

@ammichael
Copy link

@ismdcf actually the PR is not mine. I just changed the same line, in the same file, and worked like a charm.

About your error, seems like the problem is something in your code (but hey, I may be wrong)

@digitalcatnip
Copy link

@ismdcf Not sure if you solved the issue, but it looks like loadImageWithURLRequest requires an NSURLRequest, and the existing code passes an NSString, causing the error.

This code fixes the issue:

NSURL *url = [NSURL URLWithString:imageUrl];
NSURLRequest *request = [[NSURLRequest alloc] initWithURL:url];
[loader loadImageWithURLRequest:request callback:^(NSError *error, id imageOrData) {

@ismdcf
Copy link

ismdcf commented Oct 3, 2016

yep it did not work .Tk @digitalcatnip It now works .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants