RN 0.32.0 - loadImageWithTag is now loadImageWithURLRequest #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naoufal any chance we can land this small change and bump the version? Thanks! |
andue
pushed a commit
to andue/react-native-activity-view
that referenced
this pull request
Sep 24, 2016
switch back when pr closed (naoufal#56)
|
@JBerendes I don't see how this will work - in my version of code imageURL is an NSString and loadImageWithURLRequest requires an NSURLRequest. |
|
@digitalcatnip, I think you are correct here. What I'm getting out of it is a functional side-effect. In other words the activity view will show up where it wouldn't before this change. I'll take another crack at it. |
|
@JBerendes This was the code that I used to fix it in my local project: |
|
Bump to get this merged in! |
|
Bump! BTW, hey @ryancoughlin! Fancy seeing you here lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple name change to get this working with RN 0.32.0