Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a popup which displays the valid rules of a username while signing up #1312

Merged

Conversation

devArghya-0155
Copy link
Contributor

@devArghya-0155 devArghya-0155 commented Dec 12, 2023

fixes #1311 I have added a div which displays the valid rules of a username while signing up. The div will be visible until a correct username is entered. I have also introduced some additional styling during sign up. I am new to open source so please let me know my errors. I will rectify them as soon as possible.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you devArghya-0155! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there devArghya-0155!, congratulations on your first pull request :)

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954
Copy link
Owner

narayan954 commented Dec 13, 2023

I have added a div which displays the valid rules of a username while signing up. The div will be visible until a correct username is entered. I have also introduced some additional styling during sign up. I am new to open source so please let me know my errors. I will rectify them as soon as possible.

you did great! :) By the way, you can link the issues while creating pull requests by mentioning it something like "fixes #issueNumber" so maintainer could directly reference and review the pr faster. I've updated you pr comment to show that.

@narayan954 narayan954 merged commit 660c7fe into narayan954:master Dec 13, 2023
6 of 8 checks passed
@devArghya-0155
Copy link
Contributor Author

I have added a div which displays the valid rules of a username while signing up. The div will be visible until a correct username is entered. I have also introduced some additional styling during sign up. I am new to open source so please let me know my errors. I will rectify them as soon as possible.

you did great! :) By the way, you can link the issues while creating pull requests by mentioning it something like "fixes #issueNumber" so maintainer could directly reference and review the pr faster. I've updated you pr comment to show that.

I will keep this in mind next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Username Rules
2 participants