-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added a popup which displays the valid rules of a username while signing up #1312
feat: added a popup which displays the valid rules of a username while signing up #1312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you devArghya-0155! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there devArghya-0155!, congratulations on your first pull request :)
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 4 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
you did great! :) By the way, you can link the issues while creating pull requests by mentioning it something like "fixes #issueNumber" so maintainer could directly reference and review the pr faster. I've updated you pr comment to show that. |
I will keep this in mind next time! |
fixes #1311 I have added a div which displays the valid rules of a username while signing up. The div will be visible until a correct username is entered. I have also introduced some additional styling during sign up. I am new to open source so please let me know my errors. I will rectify them as soon as possible.