Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request - Date Indication in Messaging Section #1314 #1315

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

Swetha-Baskaran
Copy link
Contributor

@Swetha-Baskaran Swetha-Baskaran commented Dec 16, 2023

Issue Id: #1314

Screenshots:
image
image
image
image
image

Glad to work with Dummygram :)

@narayan954 Pls review my PR. Let me know for further corrections and changes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Swetha-Baskaran! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there Swetha-Baskaran!, congratulations on your first pull request :)

@narayan954
Copy link
Owner

narayan954 commented Dec 17, 2023

Hi @Swetha-Baskaran this looks really great, will be reviewing asap, meanwhile can you please fix those minor issues mentioned by solarcloud analysis? (removing unused imports)

Thanks

@narayan954
Copy link
Owner

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

@narayan954
Copy link
Owner

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

@Swetha-Baskaran
Copy link
Contributor Author

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

done

@Swetha-Baskaran
Copy link
Contributor Author

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

sure I'll try raise other pr for that issue

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@narayan954
Copy link
Owner

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

sure I'll try raise other pr for that issue

It's related to how we handle scrollTop function. It's conflicting while loading more messages. We can solve this later. I'm merging this now :)

@narayan954 narayan954 merged commit abf4fc7 into narayan954:master Dec 17, 2023
7 of 8 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution! This looks really good, I couldn't even think of this :)

@narayan954 narayan954 linked an issue Dec 17, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement Request - Date Indication in Messaging Section
2 participants