Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #387, Update minor out-of-family naming/consistency issues in CF #388

Merged
merged 1 commit into from
Oct 3, 2024

Fix #387, Update minor out-of-family naming/consistency issues in CF

f928452
Select commit
Loading
Failed to load commit list.
Merged

Fix #387, Update minor out-of-family naming/consistency issues in CF #388

Fix #387, Update minor out-of-family naming/consistency issues in CF
f928452
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Sep 27, 2024 in 5s

11 new alerts

New alerts in code changed by this pull request

  • 4 warnings
  • 7 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 189 in fsw/src/cf_app.c

See this annotation in the file changed.

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check warning on line 290 in fsw/src/cf_app.c

See this annotation in the file changed.

Code scanning / CodeQL

Unbounded loop Warning

This loop does not have a fixed bound.

Check warning on line 269 in fsw/src/cf_app.c

See this annotation in the file changed.

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check notice on line 64 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL

Function too long Note

CF_ResetCountersCmd has too many lines (63, while 60 are allowed).

Check notice on line 64 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check warning on line 504 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 539 in fsw/src/cf_cmd.c

See this annotation in the file changed.

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check notice on line 42 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL

Function too long Note

CF_ProcessGroundCommand has too many lines (83, while 60 are allowed).

Check notice on line 42 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 107 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL

Use of non-constant function pointer Note

This call does not go through a const function pointer.

Check notice on line 132 in fsw/src/cf_dispatch.c

See this annotation in the file changed.

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.